mjsax commented on code in PR #20329:
URL: https://github.com/apache/kafka/pull/20329#discussion_r2278443827
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -492,54 +491,60 @@ <h4><a class="toc-backref"
href="#id45">num.standby.replicas</a><a class="header
The default of <code>-1</code> (meaning: use broker default
replication factor) requires broker version 2.4 or newer.</td>
<td><code class="docutils literal"><span
class="pre">-1</span></code></td>
</tr>
- <tr class="row-odd"><td>retry.backoff.ms</td>
+ <tr class="row-odd"><td>repartition.purge.interval.ms</td>
+ <td>Low</td>
+ <td colspan="2">The frequency in milliseconds with which to delete
fully consumed records from repartition topics. Purging will occur after at
least this value since the last purge, but may be delayed until later.
+ (Note, unlike <code class="docutils literal"><span
class="pre">commit.interval.ms</span></code>, the default for this value
remains unchanged when <code class="docutils literal"><span
class="pre">processing.guarantee</span></code> is set to <code class="docutils
literal"><span class="pre">exactly_once_v2</span></code>)</td>
Review Comment:
Do we need to highlight this?
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -297,13 +297,13 @@ <h4><a class="toc-backref"
href="#id45">num.standby.replicas</a><a class="header
</tr>
<tr class="row-even"><td>commit.interval.ms</td>
<td>Low</td>
- <td colspan="2">The frequency in milliseconds with which to save
the position (offsets in source topics) of tasks.</td>
+ <td colspan="2">The frequency in milliseconds with which to save
the position (offsets in source topics) of tasks. Note that if exactly-once
processing is enabled, then the default changes to <code class="docutils
literal"><span class="pre">100</span></code></td>
Review Comment:
Great addition. But I would put it into "Default Value" column.
> `30000` (30 seconds) (at-least-once) / `100` (exactly-once)
Or something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
