mjsax commented on code in PR #18800:
URL: https://github.com/apache/kafka/pull/18800#discussion_r2162783857
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -531,6 +522,7 @@ private KStream<K, V> doRepartition(final Repartitioned<K,
V> repartitioned) {
);
final UnoptimizableRepartitionNode<K, V> unoptimizableRepartitionNode
= unoptimizableRepartitionNodeBuilder.build();
+ unoptimizableRepartitionNode.requireRepartitionByKey();
Review Comment:
Not sure about the naming and semantics of this method? We have a
repartition node at hand, which, well, always repartitions. So it does not care
about upstream repartition requirements, and returns a partitioned `KStream`
(so downstream, it's not necessary to repartition again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
