pjl1070048431 opened a new pull request, #20360: URL: https://github.com/apache/kafka/pull/20360
Currently, the following validation checks are performed twice for each partition placement: throwInvalidReplicationFactorIfNonPositive() throwInvalidReplicationFactorIfTooFewBrokers() throwInvalidReplicationFactorIfZero() These checks are already performed in the public place() method before the partition placement loop begins. Since the cluster state and replication factor don't change during the placement operation, these checks only need to be performed once. This redundant validation could be removed from the inner loop to improve performance, especially when placing many partitions. Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some commentary, upload images, or include other supplemental information that should not be part of the eventual commit message, please use a separate comment. If applicable, please include a summary of the testing strategy (including rationale) for the proposed change. Unit and/or integration tests are expected for any behavior change and system tests should be considered for larger changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
