[ 
https://issues.apache.org/jira/browse/KAFKA-18157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014624#comment-18014624
 ] 

Ksolves India Limited commented on KAFKA-18157:
-----------------------------------------------

[~chia7712] Yes, we’ve reviewed the [PR 
#18072|https://github.com/apache/kafka/pull/18072]. The linked PR was opened 
back in December 2024 and appears to have been closed because of no activity. 
It also has merge conflicts and may need updates to include the latest changes.

As we don't have write access to the PR, there's no review comment, and merge 
conflicts as well, so we believe creating a new PR would be a better approach.

> Consider UnsupportedVersionException child class to represent the case of 
> unsupported fields
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-18157
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18157
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Lianet Magrans
>            Assignee: TengYao Chi
>            Priority: Minor
>
> [https://github.com/apache/kafka/pull/17989#discussion_r1869333289] 
>  
> Adding more pointers, I expect that when the Unsupported exceptions is due to 
> fields validation it comes from building the request on 
> [https://github.com/apache/kafka/blob/f60382bf21601b1c6708d094fadb13de59a77278/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L582]
>  , vs when it happens because the API is not supported, it should be detected 
> when checking the usable version on 
> [https://github.com/apache/kafka/blob/81447c7c9543d56e2fce76b861d3918d4cac6a2a/clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java#L155]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to