jack2012aa commented on code in PR #20381: URL: https://github.com/apache/kafka/pull/20381#discussion_r2286989779
########## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ########## @@ -969,20 +970,28 @@ public void testTopicRefreshInMetadata() throws InterruptedException { final Time time = new MockTime(); final ProducerMetadata metadata = new ProducerMetadata(refreshBackoffMs, refreshBackoffMaxMs, metadataExpireMs, metadataIdleMs, new LogContext(), new ClusterResourceListeners(), time); + final String warmupTopic = "warmup-topic"; Review Comment: The first metadata update is used to update the cluster information. Adding another topic can better indicating that the update is just for warmup. It is also used in line 1083 to indicate that this update is to clean the expired topic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org