chia7712 commented on code in PR #20342:
URL: https://github.com/apache/kafka/pull/20342#discussion_r2287635937
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -2050,10 +2047,13 @@ public void close() {
} finally {
Review Comment:
If the purpose of this PR is to ensure the requests are handled gracefully,
should we also consider increasing the wait time?
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -2050,10 +2047,13 @@ public void close() {
} finally {
removeMetrics();
}
-
leaderCopyRLMTasks.clear();
leaderExpirationRLMTasks.clear();
followerRLMTasks.clear();
+
+ Utils.closeQuietly(indexCache, "RemoteIndexCache");
Review Comment:
Could you please add comments explaining the new close order? Otherwise, it
might be unintentionally changed in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
