knoxy5467 commented on code in PR #20358: URL: https://github.com/apache/kafka/pull/20358#discussion_r2288923577
########## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ########## @@ -514,7 +514,12 @@ public int splitAndReenqueue(ProducerBatch bigBatch) { // the split doesn't happen too often. CompressionRatioEstimator.setEstimation(bigBatch.topicPartition.topic(), compression.type(), Math.max(1.0f, (float) bigBatch.compressionRatio())); - Deque<ProducerBatch> dq = bigBatch.split(this.batchSize); + int maxBatchSize = this.batchSize; Review Comment: I don't have a strong opinion on the name. Will wrap rename in with revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org