ShivsundarR commented on PR #20283: URL: https://github.com/apache/kafka/pull/20283#issuecomment-3209213770
Hi @AndrewJSchofield , Thanks for the review. I have addressed the comments and updated the PR. > Could you please check that the share consumer metrics are properly tidied up when the share consumer close? - Yes I checked this, we are closing all the associated metrics when we close the share consumer. > I'm not sure why ShareConsumerMetrics and KafkaShareConsumerMetrics both has CONSUMER_SHARE_METRIC_GROUP_PREFIX as constructor arguments - Yes, ideally we need not have the prefix passed as an argument, but I think to maintain consistency with `KafkaConsumerMetrics` and `ConsumerMetrics`, we might have done this. - I have removed the parameter from `KafkaShareConsumerMetrics`, `ShareConsumerMetrics` and `KafkaConsumerMetrics`, `ConsumerMetrics`. Additionally, we were having the same group name (consumer-metrics) for the `AsyncConsumerMetrics` initialised by both `ShareConsumerImpl` and `AsyncKafkaConsumer`. I have now added prefix as an argument for `AsyncConsumerMetrics` class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
