chia7712 commented on code in PR #20366:
URL: https://github.com/apache/kafka/pull/20366#discussion_r2291759002
##########
core/src/main/scala/kafka/raft/KafkaRaftManager.scala:
##########
@@ -292,12 +260,8 @@ class KafkaRaftManager[T](
(controllerListenerName, networkClient)
}
- override def leaderAndEpoch: LeaderAndEpoch = {
- client.leaderAndEpoch
- }
-
- override def voterNode(id: Int, listener: ListenerName): Option[Node] = {
- client.voterNode(id, listener).toScala
+ override def voterNode(id: Int, listener: ListenerName): Optional[Node] = {
+ client.voterNode(id, listener)
Review Comment:
If the delegation is only a single line and the `client` is an interface,
perhaps we don't need to wrap it with `RaftManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
