AndrewJSchofield commented on code in PR #20361:
URL: https://github.com/apache/kafka/pull/20361#discussion_r2293553133
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -230,40 +230,50 @@ static List<byte[]> readPayloadFile(String
payloadFilePath, String payloadDelimi
/** Get the command-line argument parser. */
static ArgumentParser argParser() {
ArgumentParser parser = ArgumentParsers
- .newArgumentParser("producer-performance")
+ .newArgumentParser("kafka-producer-perf-test")
.defaultHelp(true)
.description("This tool is used to verify the producer
performance. To enable transactions, " +
- "you can specify a transaction id or set a transaction
duration using --transaction-duration-ms. " +
- "There are three ways to specify the transaction id:
set transaction.id=<id> via --producer-props, " +
- "set transaction.id=<id> in the config file via
--producer.config, or use --transaction-id <id>.");
+ "you can specify a transactional id or set a
transaction duration using --transaction-duration-ms. " +
+ "There are three ways to specify the transactional id:
set transactional.id=<id> via --command-property, " +
+ "set transactional.id=<id> in the config file via
--command-config, or use --transactional-id <id>.");
+
+ parser.addArgument("--bootstrap-server")
Review Comment:
Good idea, but I think a single task to do the entire KIP once the PRs are
done is best. https://issues.apache.org/jira/browse/KAFKA-19635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
