chia7712 commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r2296809389
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -185,6 +190,52 @@ object DynamicBrokerConfig {
}
props
}
+
+ private[server] def readDynamicBrokerConfigsFromSnapshot(
+ raftManager: KafkaRaftManager[ApiMessageAndVersion],
+ config: KafkaConfig,
+ quotaManagers: QuotaFactory.QuotaManagers
+ ): Unit = {
+ def putOrRemoveIfNull(props: Properties, key: String, value: String): Unit
= {
+ if (value == null) {
+ props.remove(key)
+ } else {
+ props.put(key, value)
+ }
+ }
+ raftManager.replicatedLog.latestSnapshotId().ifPresent(latestSnapshotId =>
{
+
raftManager.replicatedLog.readSnapshot(latestSnapshotId).ifPresent(rawSnapshotReader
=> {
+ val reader = RecordsSnapshotReader.of(
+ rawSnapshotReader,
+ raftManager.recordSerde,
+ BufferSupplier.create(),
+ KafkaRaftClient.MAX_BATCH_SIZE_BYTES,
+ true
+ )
+ val dynamicPerBrokerConfigs = new Properties()
+ val dynamicDefaultConfigs = new Properties()
+ while (reader.hasNext) {
+ val batch = reader.next()
+ batch.forEach(record => {
+ if (record.message().apiKey() ==
MetadataRecordType.CONFIG_RECORD.id) {
+ val configRecord = record.message().asInstanceOf[ConfigRecord]
+ if
(DynamicBrokerConfig.AllDynamicConfigs.contains(configRecord.name()) &&
+ configRecord.resourceType() ==
ConfigResource.Type.BROKER.id()) {
+ if (configRecord.resourceName().isEmpty) {
+ putOrRemoveIfNull(dynamicDefaultConfigs,
configRecord.name(), configRecord.value())
+ } else if (configRecord.resourceName() ==
config.brokerId.toString) {
+ putOrRemoveIfNull(dynamicPerBrokerConfigs,
configRecord.name(), configRecord.value())
+ }
+ }
+ }
+ })
+ }
+ val configHandler = new BrokerConfigHandler(config, quotaManagers)
+ configHandler.processConfigChanges("", dynamicPerBrokerConfigs)
Review Comment:
`dynamicPerBrokerConfigs` should be replaced by `dynamicDefaultConfigs`. I
have opened https://issues.apache.org/jira/browse/KAFKA-19642 to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
