apoorvmittal10 commented on code in PR #20411:
URL: https://github.com/apache/kafka/pull/20411#discussion_r2301172432
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -1181,7 +1182,7 @@ public void testMaybeInitializeAndAcquire() {
assertEquals(RecordState.ACQUIRED,
sharePartition.cachedState().get(26L).batchState());
assertEquals(30L, sharePartition.endOffset());
// As all the gaps are now filled, the initialReadGapOffset should be
null.
Review Comment:
Done.
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -1279,7 +1280,7 @@ public void
testMaybeInitializeAndAcquireWithHigherMaxFetchRecords() {
assertEquals(RecordState.ACQUIRED,
sharePartition.cachedState().get(31L).batchState());
assertEquals(49L, sharePartition.endOffset());
// As all the gaps are now filled, the initialReadGapOffset should be
null.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
