mjsax commented on code in PR #20260: URL: https://github.com/apache/kafka/pull/20260#discussion_r2305521015
########## streams/upgrade-system-tests-0110/src/main/java/org/apache/kafka/streams/StreamsUpgradeTest.java: ########## @@ -14,11 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.streams.tests; +package org.apache.kafka.streams; Review Comment: Seems we need to change the package name, to avoid conflicts with the "main" `StreamsUpgradeTest.java` ? Could this cause issue when running the corresponding upgrade system test? We hardcode the same name across all version (including `trunk`) https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/streams.py#L601 This will all be quite tricky to clean up, as older jar we currently load, will provide the old name... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
