chia7712 commented on code in PR #20396:
URL: https://github.com/apache/kafka/pull/20396#discussion_r2307348317
##########
tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java:
##########
@@ -240,13 +250,16 @@ public static void main(String[] args) throws Exception {
CommandLineUtils.checkRequiredArgs(parser, optionSet,
options.brokerOpt, options.numMessagesOpt);
long messages = optionSet.valueOf(options.numMessagesOpt);
- String compressionType =
optionSet.valueOf(options.messageCompressionOpt);
+ CompressionType compressionType =
CompressionType.forName(optionSet.valueOf(options.messageCompressionOpt));
+ Integer compressionLevel =
optionSet.valueOf(options.compressionLevelOpt);
int percentDeletes = optionSet.valueOf(options.percentDeletesOpt);
int dups = optionSet.valueOf(options.numDupsOpt);
String brokerUrl = optionSet.valueOf(options.brokerOpt);
int topicCount = optionSet.valueOf(options.topicsOpt);
int sleepSecs = optionSet.valueOf(options.sleepSecsOpt);
+ CompressionType.forName(compressionType.name.toLowerCase(Locale.ROOT));
Review Comment:
this is unnecessary, right? line#253 has covered it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
