squah-confluent commented on code in PR #19967:
URL: https://github.com/apache/kafka/pull/19967#discussion_r2307448948
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1913,6 +1914,11 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
// to persist the change, and bump the group epoch later.
boolean bumpGroupEpoch = hasStreamsMemberMetadataChanged(groupId,
member, updatedMember, records);
+ // Check if StreamsGroup has flag rebalanceRequired equals to true
+ if (group.rebalanceRequired()) {
+ bumpGroupEpoch = true;
+ }
+
Review Comment:
Instead of adding a new flag, we can bump the epoch directly when a config
of interest changes and this will trigger a new assignment on the next
heartbeat. As an example, we do this in `handleRegularExpressionsResult` to
trigger a new assignment on the next heartbeat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
