AndrewJSchofield commented on code in PR #20385:
URL: https://github.com/apache/kafka/pull/20385#discussion_r2307725001
##########
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##########
@@ -292,13 +296,18 @@ public ConsumerPerfOptions(String[] args) {
.ofType(Integer.class)
.defaultsTo(1024 * 1024);
resetBeginningOffsetOpt = parser.accepts("from-latest", "If the
consumer does not already have an established " +
- "offset to consume from, start with the latest message present
in the log rather than the earliest message.");
+ "offset to consume from, start with the latest record present
in the log rather than the earliest record.");
socketBufferSizeOpt = parser.accepts("socket-buffer-size", "The
size of the tcp RECV size.")
.withRequiredArg()
.describedAs("size")
.ofType(Integer.class)
.defaultsTo(2 * 1024 * 1024);
- consumerConfigOpt = parser.accepts("consumer.config", "Consumer
config properties file.")
+ consumerConfigOpt = parser.accepts("consumer.config",
"(DEPRECATED) Consumer config properties file. " +
+ "This option will be removed in a future version.
Use --command-config instead")
Review Comment:
Missing `.`.
##########
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##########
@@ -292,13 +296,18 @@ public ConsumerPerfOptions(String[] args) {
.ofType(Integer.class)
.defaultsTo(1024 * 1024);
resetBeginningOffsetOpt = parser.accepts("from-latest", "If the
consumer does not already have an established " +
- "offset to consume from, start with the latest message present
in the log rather than the earliest message.");
+ "offset to consume from, start with the latest record present
in the log rather than the earliest record.");
socketBufferSizeOpt = parser.accepts("socket-buffer-size", "The
size of the tcp RECV size.")
.withRequiredArg()
.describedAs("size")
.ofType(Integer.class)
.defaultsTo(2 * 1024 * 1024);
- consumerConfigOpt = parser.accepts("consumer.config", "Consumer
config properties file.")
+ consumerConfigOpt = parser.accepts("consumer.config",
"(DEPRECATED) Consumer config properties file. " +
+ "This option will be removed in a future version.
Use --command-config instead")
+ .withRequiredArg()
+ .describedAs("config file")
+ .ofType(String.class);
+ commandConfigOpt = parser.accepts("command-config", "Config
properties file")
Review Comment:
nit: Please make sure all of the help messages end with `.`.
##########
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##########
@@ -310,7 +319,12 @@ public ConsumerPerfOptions(String[] args) {
.describedAs("milliseconds")
.ofType(Long.class)
.defaultsTo(10_000L);
- numMessagesOpt = parser.accepts("messages", "REQUIRED: The number
of messages to consume.")
+ numMessagesOpt = parser.accepts("messages", "(DEPRECATED) The
number of records to consume. " +
+ "This option will be removed in a future version.
Use --num-records instead")
Review Comment:
Missing `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
