kamalcph commented on code in PR #20256:
URL: https://github.com/apache/kafka/pull/20256#discussion_r2307900595


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2347,6 +2347,7 @@ class ReplicaManager(val config: KafkaConfig,
     // Before taking the lock, compute the local changes
     val localChanges = delta.localChanges(config.nodeId)
     val metadataVersion = newImage.features().metadataVersionOrThrow()
+    val deletedTopicIdMap = delta.image().topicNameToIdView()

Review Comment:
   nit: 
   
   Can this be renamed to `deletedTopicIdMap` -> `topicNamesToIds` or 
`topicIdMap`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to