[ 
https://issues.apache.org/jira/browse/KAFKA-19659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luke Chen updated KAFKA-19659:
------------------------------
    Description: 
This UnregisterBrokerOptions extends from the UpdateFeaturesOptions, which is 
obviously wrong.

[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/UnregisterBrokerOptions.java#L23]

 

And that's why in KafkaAdminClientTest.java, we set timeout via 
`options.timeoutMs = 10;`. We should set it via timeoutMs(int) method 
gracefully like other tests.

  was:
This UnregisterBrokerOptions extends from the UpdateFeaturesOptions, which is 
obviously wrong.

[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/UnregisterBrokerOptions.java#L23]

 

And that's why in KafkaAdminClientTest.java, we set timeout via 
`options.timeoutMs = 10;`. We should set it via timeoutMs() method gracefully 
like other tests.


> Wrong generic type for UnregisterBrokerOptions
> ----------------------------------------------
>
>                 Key: KAFKA-19659
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19659
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Luke Chen
>            Priority: Major
>
> This UnregisterBrokerOptions extends from the UpdateFeaturesOptions, which is 
> obviously wrong.
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/UnregisterBrokerOptions.java#L23]
>  
> And that's why in KafkaAdminClientTest.java, we set timeout via 
> `options.timeoutMs = 10;`. We should set it via timeoutMs(int) method 
> gracefully like other tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to