mjsax commented on code in PR #20470: URL: https://github.com/apache/kafka/pull/20470#discussion_r2319951023
########## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ########## @@ -1306,7 +1306,12 @@ public <KOut, VOut> KStream<KOut, VOut> process( final ProcessorToStateConnectorNode<? super K, ? super V> processNode = new ProcessorToStateConnectorNode<>( name, new ProcessorParameters<>(processorSupplier, name), - stateStoreNames); + stateStoreNames + ); + if (builder.processProcessValueFixEnabled()) { Review Comment: I also added this here -- it's atm not strictly necessary, because `process()` is key-changing, what we track via `repartitionRequired` flag further below, setting it to `true` via `KStreamImpl` constructor. but it just feel correct to add anyway, as we have plans to actually unify `repartitionRequired`, and `keyChanging` flags. So we need to make sure we don't miss this one... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org