chia7712 commented on code in PR #20443: URL: https://github.com/apache/kafka/pull/20443#discussion_r2319896962
########## server-common/src/test/java/org/apache/kafka/server/util/timer/TimingWheelTest.java: ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.util.timer; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.util.concurrent.DelayQueue; +import java.util.concurrent.atomic.AtomicInteger; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertSame; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class TimingWheelTest { + + private TimingWheel timingWheel; + private AtomicInteger taskCounter; + private DelayQueue<TimerTaskList> queue; + private final long startMs = 1000L; + private final long tickMs = 10L; + private final int wheelSize = 5; + + @BeforeEach Review Comment: those variables could be initialized in constructor, right? ```java private final long startMs = 1000L; private final long tickMs = 10L; private final int wheelSize = 5; private final DelayQueue<TimerTaskList> queue = new DelayQueue<>(); private final AtomicInteger taskCounter = new AtomicInteger(0); private final TimingWheel timingWheel = new TimingWheel(tickMs, wheelSize, startMs, taskCounter, queue); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
