frankvicky commented on code in PR #20472:
URL: https://github.com/apache/kafka/pull/20472#discussion_r2321452584
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1833,6 +1838,9 @@ public void close(Duration timeout) {
* {@link ConsumerConfig#REQUEST_TIMEOUT_MS_CONFIG} for these requests to
complete during the close operation.
* Note that the execution time of callbacks (such as {@link
OffsetCommitCallback} and
* {@link ConsumerRebalanceListener}) does not consume time from the close
timeout.
+ * <p>
+ * This close operation will attempt all shutdown steps even if one of
them fails.
+ * It logs all encountered errors, continues to execute the next steps,
and finally throws the first error found.
Review Comment:
+1, makes sense to me to align these comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
