JimmyWang6 commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2324278765
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1784,15 +1784,15 @@ class KafkaConfigTest {
props.put(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
"consumer")
assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props))
+
Review Comment:
nit: extra blank.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -69,6 +69,11 @@ public class GroupCoordinatorConfig {
Group.GroupType.CLASSIC.toString(),
Group.GroupType.CONSUMER.toString(),
Group.GroupType.STREAMS.toString());
+ public static final List<String>
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_ALLOWED = List.of(
Review Comment:
I think we could reuse the `GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT`
constant since they are exactly the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
