chia7712 commented on code in PR #19513: URL: https://github.com/apache/kafka/pull/19513#discussion_r2327711607
########## gradle/dependencies.gradle: ########## @@ -119,13 +119,13 @@ versions += [ // When updating the scalafmt version please also update the version field in checkstyle/.scalafmt.conf. scalafmt now // has the version field as mandatory in its configuration, see // https://github.com/scalameta/scalafmt/releases/tag/v3.1.0. - scalafmt: "3.7.14", - scoverage: "2.0.11", + scalafmt: "3.9.9", Review Comment: Are those changes necessary? ########## .github/actions/setup-gradle/action.yml: ########## @@ -42,7 +42,7 @@ runs: distribution: temurin java-version: ${{ inputs.java-version }} - name: Setup Gradle - uses: gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b # v4.3.0 Review Comment: Could you please use the git commit hash instead, to follow the Apache policy (see below)? > You MUST pin all external actions to the specific git hash (SHA1) of the action that has been reviewed for use by the project. For instance, you MUST pin foobar/baz-action@8843d7f92416211de9ebb963ff4ce28125932878. reference: https://infra.apache.org/github-actions-policy.html ########## .github/workflows/build.yml: ########## @@ -164,7 +164,7 @@ jobs: # Check if there are any empty files under ./site-docs/generated, If any empty files are found, print an error # message and list the empty files run: | - tar zxvf core/build/distributions/kafka_2.13-$(./gradlew properties | grep version: | awk '{print $NF}' | head -n 1)-site-docs.tgz + tar zxvf distribution/build/distributions/kafka_2.13-$(./gradlew properties | grep version: | awk '{print $NF}' | head -n 1)-site-docs.tgz Review Comment: Changing the path may break downstream CI or workflows. Could you please provide more details about this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
