mimaison commented on code in PR #20480:
URL: https://github.com/apache/kafka/pull/20480#discussion_r2337294418


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -443,6 +443,12 @@ public class StreamsConfig extends AbstractConfig {
     @SuppressWarnings("WeakerAccess")
     public static final String UPGRADE_FROM_40 = 
UpgradeFromValues.UPGRADE_FROM_40.toString();
 
+    /**
+     * Config value for parameter {@link #UPGRADE_FROM_CONFIG "upgrade.from"} 
for upgrading an application from version {@code 4.1.x}.
+     */
+    @SuppressWarnings("WeakerAccess")
+    public static final String UPGRADE_FROM_41 = 
UpgradeFromValues.UPGRADE_FROM_41.toString();

Review Comment:
   Actually we should delete the `Accepted values are ...` from the 
description. The config is defined with a `Validator` so we already print the 
valid values in the docs: 
https://kafka.apache.org/documentation/#streamsconfigs_upgrade.from



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to