AndrewJSchofield commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2352799590
########## tests/kafkatest/services/performance/share_consumer_performance.py: ########## @@ -100,7 +100,7 @@ def start_cmd(self, node): for key, value in self.args().items(): cmd += " --%s %s" % (key, value) - cmd += " --consumer.config %s" % ShareConsumerPerformanceService.CONFIG_FILE + cmd += " --command-config %s" % ShareConsumerPerformanceService.CONFIG_FILE Review Comment: I think you need to protect this with `if node.version.supports_command_config():` because this will run on AK 4.1 (which doesn't support it) and later (which will). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org