Copilot commented on code in PR #20559:
URL: https://github.com/apache/kafka/pull/20559#discussion_r2362112626
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##########
@@ -220,8 +214,7 @@ public static class DeadlineAndEpoch {
public StreamsGroup(
LogContext logContext,
SnapshotRegistry snapshotRegistry,
- String groupId,
- GroupCoordinatorMetricsShard metrics
+ String groupId
) {
Review Comment:
The removal of the GroupCoordinatorMetricsShard constructor parameter is a
breaking change to this public constructor. If StreamsGroup is intended for
external (non-internal) use, consider a deprecation cycle or documenting the
change in release notes; otherwise, mark the class or constructor clearly as
internal to avoid unintended API breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
