Yunyung commented on code in PR #20445:
URL: https://github.com/apache/kafka/pull/20445#discussion_r2377340161
##########
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##########
@@ -585,15 +582,16 @@ private static class StreamsResetterOptions extends
CommandDefaultOptions {
public StreamsResetterOptions(String[] args) {
super(args);
- applicationIdOption = parser.accepts("application-id", "The Kafka
Streams application ID (application.id).")
+ applicationIdOption = parser.accepts("application-id", "REQUIRED:
The Kafka Streams application ID (application.id).")
.withRequiredArg()
.ofType(String.class)
.describedAs("id")
.required();
- bootstrapServerOption = parser.accepts("bootstrap-server", "The
server(s) to connect to. The broker list string in the form
HOST1:PORT1,HOST2:PORT2. (default: localhost:9092)")
+ bootstrapServerOption = parser.accepts("bootstrap-server",
"REQUIRED: The server(s) to connect to. The broker list string in the form
HOST1:PORT1,HOST2:PORT2.")
.withRequiredArg()
.ofType(String.class)
- .describedAs("server to connect to");
+ .describedAs("server to connect to")
+ .required();
Review Comment:
I'll revert the change that requires bootstrapServer, since the previous
[KIP-865](https://cwiki.apache.org/confluence/display/KAFKA/KIP-865%3A+Support+--bootstrap-server+in+kafka-streams-application-reset)
is ambiguous and highly dependent on the implementation. It's better not to
introduce the breaking change here.
That is, this PR only updates the docs and text. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
