chia7712 commented on code in PR #20526:
URL: https://github.com/apache/kafka/pull/20526#discussion_r2379662485
##########
metadata/src/main/java/org/apache/kafka/metadata/MetadataVersionConfigValidator.java:
##########
@@ -24,18 +24,20 @@
import org.apache.kafka.server.common.MetadataVersion;
import org.apache.kafka.server.fault.FaultHandler;
+import java.util.function.Supplier;
+
public class MetadataVersionConfigValidator implements MetadataPublisher {
private final String name;
- private final KafkaConfig config;
+ private final Supplier<Boolean> hasMultiLogDirs;
private final FaultHandler faultHandler;
public MetadataVersionConfigValidator(
- KafkaConfig config,
- FaultHandler faultHandler
+ int brokerId,
+ Supplier<Boolean> hasMultiLogDirs,
+ FaultHandler faultHandler
) {
- int id = config.brokerId();
- this.name = "MetadataVersionPublisher(id=" + id + ")";
- this.config = config;
+ this.name = "MetadataVersionPublisher(id=" + brokerId + ")";
Review Comment:
Could you please align the naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
