chia7712 commented on code in PR #20475:
URL: https://github.com/apache/kafka/pull/20475#discussion_r2375608168
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -60,7 +60,8 @@ import org.apache.kafka.common.{Node, TopicIdPartition,
TopicPartition, Uuid}
import org.apache.kafka.coordinator.group.{Group, GroupConfig,
GroupConfigManager, GroupCoordinator}
import org.apache.kafka.coordinator.share.ShareCoordinator
import org.apache.kafka.metadata.{ConfigRepository, MetadataCache}
-import org.apache.kafka.server.{ApiVersionManager, ClientMetricsManager,
DelegationTokenManager, ProcessRole}
+import org.apache.kafka.security.DelegationTokenManager
Review Comment:
This comment is unrelated to this PR, but `DelegationTokenManager` should
expose an `isEnabled` method, similar to `DelegationTokenControlManager`.
`KafkaAPIs` could then leverage this method to avoid repeatedly creating
`DelegationTokenManagerConfigs`
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L2316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
