Copilot commented on code in PR #20592:
URL: https://github.com/apache/kafka/pull/20592#discussion_r2382260120
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##########
@@ -711,9 +726,8 @@ public void
shouldNotViolateEosIfOneTaskGetsFencedUsingIsolatedAppInstances(fina
expectedCommittedRecordsAfterRebalance,
"The all committed records after rebalance do not match what
expected");
- LOG.info("Releasing Stall");
doStall = false;
- // Once the stalling host rejoins the group, we expect both
instances to see both instances.
+ // After removing the stalling instance, we expect both remaining
instances to see both instances.
// It doesn't really matter what the assignment is, but we might
as well also assert that they
// both see both partitions assigned exactly once
Review Comment:
The comment mentions 'both remaining instances' but the code only has one
remaining instance after the stalling instance is removed. This is inconsistent
with the actual implementation where only one instance remains active.
```suggestion
// After removing the stalling instance, we expect the single
remaining instance to see only itself as a member.
// It doesn't really matter what the assignment is, but we might
as well also assert that it
// sees both partitions assigned exactly once
```
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##########
@@ -605,12 +626,11 @@ public void
shouldNotViolateEosIfOneTaskGetsFencedUsingIsolatedAppInstances(fina
// -> the stall only affects one thread and should trigger a rebalance
// after rebalancing, we should read 40 committed records (even if 50
record got written)
//
- // afterward, the "stalling" thread resumes, and another rebalance
should get triggered
- // we write the remaining 20 records and verify to read 60 result
records
+ // after the stalling instance is removed, we write the remaining 20
records and verify to read 60 result records
Review Comment:
The comment mentions 'both remaining instances' but the code only has one
remaining instance after the stalling instance is removed. This is inconsistent
with the actual implementation where only one instance remains active.
```suggestion
// after the stalling instance is removed, the remaining instance
writes the remaining 20 records and we verify to read 60 result records
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
