majialoong commented on code in PR #20612:
URL: https://github.com/apache/kafka/pull/20612#discussion_r2395310192
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##########
@@ -209,7 +209,7 @@ public static Set<Path> pluginLocations(String pluginPath,
boolean failFast) {
for (String path : pluginPathElements) {
try {
Path pluginPathElement = Paths.get(path).toAbsolutePath();
- if (pluginPath.isEmpty()) {
+ if (path.isEmpty()) {
Review Comment:
> I think we should also update the `ConnectPluginPath` class to validate
that `plugin.path` is not empty. However, this change might require a separate
KIP or an update to KIP-1161 to address it.
Thanks for your suggestions. I will submit a separate patch to fix the
ConnectPluginPath issue; this patch removes the corresponding changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
