mjsax commented on code in PR #20620:
URL: https://github.com/apache/kafka/pull/20620#discussion_r2396830871
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java:
##########
@@ -272,8 +272,8 @@ public void shouldAddAndRemoveThreadsMultipleTimes() throws
InterruptedException
stateTransitionHistory.clear();
final CountDownLatch latch = new CountDownLatch(2);
- final Thread one = adjustCountHelperThread(kafkaStreams, 4, latch);
- final Thread two = adjustCountHelperThread(kafkaStreams, 6, latch);
+ final Thread one = adjustCountHelperThread(kafkaStreams, 1, latch);
+ final Thread two = adjustCountHelperThread(kafkaStreams, 1, latch);
Review Comment:
Not sure if this is the right change? -- The method name literally says
`MultipleTimes` so there seems to be an intent to add/remove threads multiple
times. If we reduce this to one, it seems we are removing intended test
coverage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
