kirktrue commented on code in PR #20521:
URL: https://github.com/apache/kafka/pull/20521#discussion_r2399704514
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -218,32 +242,35 @@ public void process(ApplicationEvent event) {
}
private void process(final PollEvent event) {
+ processPollEvent(event.pollTimeMs());
+ event.markReconcileAndAutoCommitComplete();
Review Comment:
I'd noticed that the `ShareConsumerImpl` was still using `PollEvent`s, so I
didn't want to muck with it too much. It seems like I could refactor
`processPollEvent()` into two separate pieces of logic, one for the
`CompositePollEvent` and one for the (Share consumer) `PollEvent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
