0xffff-zhiyan commented on code in PR #20481:
URL: https://github.com/apache/kafka/pull/20481#discussion_r2400161448
##########
core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala:
##########
@@ -50,6 +50,7 @@ class KafkaRequestHandlerTest {
val topic2 = "topic2"
val brokerTopicMetrics: BrokerTopicMetrics =
brokerTopicStats.topicStats(topic)
val allTopicMetrics: BrokerTopicMetrics = brokerTopicStats.allTopicsStats
+ KafkaRequestHandlerPool.sharedAggregateTotalThreads.set(1)
Review Comment:
Because the `aggregateThreads` was updated by `KafkaRequestHandlerPool` but
in this test we don't create the pool so aggregateThreads is default to 0. When
the RequestHandler runs `aggregateIdleMeter.mark(idleTime /
aggregateThreads.get)` we will see an error because the divisor is 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
