mimaison commented on code in PR #20546:
URL: https://github.com/apache/kafka/pull/20546#discussion_r2429814616
##########
tests/docker/run_tests.sh:
##########
@@ -20,6 +20,14 @@ KAFKA_NUM_CONTAINERS=${KAFKA_NUM_CONTAINERS:-14}
TC_PATHS=${TC_PATHS:-./kafkatest/}
REBUILD=${REBUILD:f}
+# Auto-detect container runtime if not set
+if [[ -z "${CONTAINER_RUNTIME}" ]]; then
+ export CONTAINER_RUNTIME="docker"
+ if command -v podman &> /dev/null; then
+ export CONTAINER_RUNTIME="podman"
+ fi
Review Comment:
If you have both installed, this will pick `podman`. I wonder if this should
still default to `docker`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
