shashankhs11 commented on code in PR #20285: URL: https://github.com/apache/kafka/pull/20285#discussion_r2434310994
########## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AtLeastOnceDeliveryMessageLossIntegrationTest.java: ########## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.integration; + +import org.apache.kafka.clients.admin.Admin; +import org.apache.kafka.clients.admin.AdminClientConfig; +import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.clients.producer.internals.Sender; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.serialization.Serdes; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.kafka.common.utils.LogCaptureAppender; +import org.apache.kafka.streams.KafkaStreams; +import org.apache.kafka.streams.KeyValue; +import org.apache.kafka.streams.StreamsBuilder; +import org.apache.kafka.streams.StreamsConfig; +import org.apache.kafka.streams.integration.utils.EmbeddedKafkaCluster; +import org.apache.kafka.streams.integration.utils.IntegrationTestUtils; +import org.apache.kafka.streams.kstream.KStream; +import org.apache.kafka.test.TestUtils; + +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInfo; +import org.junit.jupiter.api.Timeout; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.time.Duration; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Properties; + +import static org.apache.kafka.common.utils.Utils.mkEntry; +import static org.apache.kafka.common.utils.Utils.mkMap; +import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.DEFAULT_TIMEOUT; +import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.cleanStateBeforeTest; +import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.purgeLocalStreamsState; +import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.startApplicationAndWaitUntilRunning; +import static org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived; +import static org.apache.kafka.streams.utils.TestUtils.safeUniqueTestName; +import static org.apache.kafka.test.TestUtils.consumerConfig; +import static org.apache.kafka.test.TestUtils.producerConfig; +import static org.apache.kafka.test.TestUtils.waitForCondition; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + + +@Timeout(600) +@Tag("integration") +public class AtLeastOnceDeliveryMessageLossIntegrationTest { + private static final Logger log = LoggerFactory.getLogger( + AtLeastOnceDeliveryMessageLossIntegrationTest.class); + + private static final int NUM_BROKERS = 1; + private static final int LARGE_RECORD_COUNT = 50000; + private static final int SMALL_RECORD_COUNT = 40000; + + public static final EmbeddedKafkaCluster CLUSTER = new EmbeddedKafkaCluster(NUM_BROKERS); + + @BeforeAll + public static void startCluster() throws IOException { + CLUSTER.start(); + } + + @AfterAll + public static void closeCluster() { + CLUSTER.stop(); + } + + private String applicationId; + private String inputTopic; + private String outputTopic; + private Properties streamsConfiguration; + private KafkaStreams kafkaStreams; + + @BeforeEach + public void setUp(final TestInfo testInfo) throws Exception { + final String testId = safeUniqueTestName(testInfo); + applicationId = "app-" + testId; + inputTopic = "input-" + testId; + outputTopic = "output-" + testId; + + cleanStateBeforeTest(CLUSTER, inputTopic, outputTopic); + CLUSTER.createTopics(inputTopic, outputTopic); + + setupStreamsConfiguration(); + } + + @AfterEach + public void cleanUp() throws Exception { + if (kafkaStreams != null) { + kafkaStreams.close(); + } + if (streamsConfiguration != null) { + purgeLocalStreamsState(streamsConfiguration); + } + } + + // failing test + @Test + public void shouldNotCommitOffsetsAndNotProduceOutputRecordsWhenProducerFailsWithMessageTooLarge() throws Exception { + + try (final LogCaptureAppender appender = LogCaptureAppender.createAndRegister(Sender.class)) { + produceInputData(LARGE_RECORD_COUNT); Review Comment: @junrao: Just a quick question for my understanding only > If I change 0 to LARGE_RECORD_COUNT in the following, the test passes, which is expected. my understanding was that if offsets are committed, then the corresponding records should have been delivered to the output topic as well, right? Or just needs to be processed and not necessarily delivered? > Since the unit test covers the bug already, I am not sure that we need AtLeastOnceDeliveryMessageLossIntegrationTest. Removed it in 0e9c522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
