kuoche1712003 commented on code in PR #20699:
URL: https://github.com/apache/kafka/pull/20699#discussion_r2438872480
##########
release/release.py:
##########
@@ -245,8 +248,8 @@ def prereq(name, soft_check):
fail(f"Pre-requisite not met: {name}. Error: {e}")
prereq('Apache Maven CLI (mvn) in PATH', lambda: "Apache Maven" in
execute("mvn -v"))
prereq("svn CLI in PATH", lambda: "svn" in execute("svn --version"))
- prereq("Verifying that you have no unstaged git changes", lambda:
git.has_unstaged_changes())
- prereq("Verifying that you have no staged git changes", lambda:
git.has_staged_changes())
+ prereq("Verifying that you have no unstaged git changes", lambda: not
git.has_unstaged_changes())
Review Comment:
This error was introduced in
https://github.com/apache/kafka/commit/30ffd42b262b6f95e45451c234f2c196050f252f#diff-241bcfc06fc20c009b77012a614513cc634006b8557f4d9cdcdc8fb8d44178e240
when if result == False was changed to if not result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
