see-quick commented on code in PR #20672: URL: https://github.com/apache/kafka/pull/20672#discussion_r2431800170
########## server/src/test/java/org/apache/kafka/server/metrics/ClientTelemetryInterfaceCompatibilityTest.java: ########## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.metrics; + +import org.apache.kafka.common.message.PushTelemetryRequestData; +import org.apache.kafka.common.requests.PushTelemetryRequest; +import org.apache.kafka.server.metrics.ClientMetricsTestUtils.TestClientMetricsReceiver; +import org.apache.kafka.server.metrics.ClientMetricsTestUtils.TestClientTelemetryExporter; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.net.UnknownHostException; +import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class ClientTelemetryInterfaceCompatibilityTest { Review Comment: First thought was to cover edge cases such as multiple exporters, receivers etc. but it also redudant test cases: 1. deprecated receiver 2. exporter 3. then check both receiver and exporter So I think, maybe we can remove those and let here just mutliple new exporters, new receivers and maybe combine both receivers and exporters? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
