zheguang commented on code in PR #20564:
URL: https://github.com/apache/kafka/pull/20564#discussion_r2375570585
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##########
@@ -898,6 +899,36 @@ public void
testConnectorStatusMetricsGroup_taskStatusCounter(boolean enableTopi
verifyKafkaClusterId();
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testConnectorStatusMetricsGroup_tasksFailedToStart(boolean
enableTopicCreation) {
+ setup(enableTopicCreation);
+ ConcurrentMap<ConnectorTaskId, WorkerTask<?, ?>> tasks = new
ConcurrentHashMap<>();
Review Comment:
Minor: to help with reading the test, I'd name this as `emptyTasks`
instantiated with immutable empty map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
