kuoche1712003 commented on code in PR #20308:
URL: https://github.com/apache/kafka/pull/20308#discussion_r2438764482
##########
release/release.py:
##########
@@ -232,12 +232,12 @@ def verify_gpg_key():
jdk21_env = get_jdk(21)
-def verify_prerequeisites():
+def verify_prerequisites():
print("Begin to check if you have met all the pre-requisites for the
release process")
def prereq(name, soft_check):
try:
result = soft_check()
- if result == False:
+ if not result:
Review Comment:
I noticed that soft_check can now return None as a possible value. I'm a bit
concerned this change might potentially affect our release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
