mjsax commented on code in PR #20403: URL: https://github.com/apache/kafka/pull/20403#discussion_r2404153695
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/InitProcessorRecordContext.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor.internals; + +import org.apache.kafka.common.header.internals.RecordHeaders; +import org.apache.kafka.common.utils.Time; + +import java.util.Objects; + +public class InitProcessorRecordContext extends ProcessorRecordContext { + + private final Time time; + + public InitProcessorRecordContext(final Time time) { + super(time.milliseconds(), -1, -1, null, new RecordHeaders()); Review Comment: I was thinking about this more, as discussed on Zoom recently, we both tend to agree that not using a fixed value might be semantically better. However, as we use a fixed value inside `process()` and `punctuate()` callback, I am concerned about consistency. So I would propose to use a fixed value for this PR. -- I am open to change it to a dynamic value, but for this case, we should also change it for `process()` and `punctuate()`, what would be a larger change (and unrelated to this bug fix). Happy to file a Jira ticket about it, and you can pick it up if you want to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
