lucasbru commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2410772891
##########
group-coordinator/src/main/resources/common/message/StreamsGroupMetadataValue.json:
##########
@@ -24,6 +24,8 @@
{ "name": "Epoch", "versions": "0+", "type": "int32",
"about": "The group epoch." },
{ "name": "MetadataHash", "versions": "0+", "type": "int64",
- "about": "The hash of all topics in the group." }
+ "about": "The hash of all topics in the group." },
+ { "name": "ValidatedTopologyEpoch", "versions": "0+", "taggedVersions":
"0+", "tag": 0, "default": -1, "type": "int32",
Review Comment:
I think the main disadvantage is that we need to encode a "tag" which is an
extra byte I believe. The only advantage is that we do not need to worry about
people enabling this on the clusters where they already tried EA. Should be
mostly Confluent. Would you rather have this cleaned and make sure we recreate
all clusters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
