MahsaSeifikar commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2375778142
##########
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##########
@@ -440,19 +441,35 @@ int size() {
*/
private boolean interrupted;
+ /**
+ * Optional callback for queue idle time tracking.
+ */
+ private final Consumer<Long> idleTimeCallback;
+
+
public KafkaEventQueue(
Time time,
LogContext logContext,
String threadNamePrefix
) {
- this(time, logContext, threadNamePrefix, VoidEvent.INSTANCE);
+ this(time, logContext, threadNamePrefix, VoidEvent.INSTANCE,
Optional.empty());
}
public KafkaEventQueue(
Time time,
LogContext logContext,
String threadNamePrefix,
Event cleanupEvent
+ ) {
+ this(time, logContext, threadNamePrefix, cleanupEvent,
Optional.empty());
+ }
+
+ public KafkaEventQueue(
+ Time time,
+ LogContext logContext,
+ String threadNamePrefix,
+ Event cleanupEvent,
+ Optional<Consumer<Long>> idleTimeCallback
Review Comment:
That's a good point! I haven't considered this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
