abhi-ksolves commented on PR #20430: URL: https://github.com/apache/kafka/pull/20430#issuecomment-3345702122
@mjsax Let me clarify the confusion. The usual practice is that whenever we need to work on a ticket, we create a new branch from trunk (for example, Kafka-<ID>), apply our changes there, and then open a PR from that branch to Kafka/trunk. In our case, @samarth-ksolves and I share the same forked Kafka repository for contributions. What happened here is that @samarth-ksolves initially created a PR directly from the forked trunk branch to Kafka/trunk. At that point, you saw 1 file change with more than 0 commits. On my side, the unmerged commits in our forked trunk branch caused issues when I tried to create a different branch. It inherited the commits from this PR. To fix this, I reset our forked trunk, which in turn resulted in this PR showing 0 commits and 0 file changes. You can see the earlier conversation above where I mentioned that I force-pushed trunk. After this whole event, @AndrewJSchofield merged the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
