shashankhs11 commented on code in PR #20692:
URL: https://github.com/apache/kafka/pull/20692#discussion_r2426527311
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -1843,11 +1835,11 @@ public void
shouldComputeOffsetSumForRestoringActiveTaskWithStateUpdater() throw
when(stateUpdater.tasks()).thenReturn(Set.of(restoringStatefulTask));
taskManager.handleRebalanceStart(singleton("topic"));
- assertThat(taskManager.taskOffsetSums(), is(mkMap(mkEntry(taskId00,
changelogOffset))));
+ assertThat(taskManager.taskOffsetSums(), is(expectedOffsetSums));
Review Comment:
This test tests the scenario after a rebalance has started with the
checkpoint state, but the one above is without rebalance handling and is a more
simpler scenario.
But, I think the above test can be omitted? -- because it seems to be
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
