m1a2st commented on code in PR #19955:
URL: https://github.com/apache/kafka/pull/19955#discussion_r2404229802
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -1453,7 +1461,9 @@ private Thread shutdownHelper(final boolean error, final
long timeoutMs, final b
return new Thread(() -> {
// notify all the threads to stop; avoid deadlocks by stopping any
// further state reports from the thread since we're shutting down
- int numStreamThreads = processStreamThread(streamThread ->
streamThread.shutdown(leaveGroup));
+ int numStreamThreads = processStreamThread(
+ streamThread -> streamThread.shutdown(operation ==
org.apache.kafka.streams.CloseOptions.GroupMembershipOperation.LEAVE_GROUP)
Review Comment:
I think updating the `StreamThread#shutdown` parameter makes sense to me, so
I will update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
