chia7712 commented on code in PR #20686: URL: https://github.com/apache/kafka/pull/20686#discussion_r2442471186
########## gradlewAll: ########## @@ -1,25 +0,0 @@ -#!/usr/bin/env sh - -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# Convenient way to invoke a gradle command with all Scala versions supported -# by default -# This script was originally designed to support multiple Scala versions (2.12 and 2.13), -# but as Scala 2.12 is no longer supported, this script is no longer necessary. -# We are keeping it for backwards compatibility. It will be removed in a future release. -echo "Warning: This script is deprecated and will be removed in a future release." Review Comment: In order to keep compatibility, this file MUST be removed in 5.0 ########## gradle/dependencies.gradle: ########## @@ -22,17 +22,7 @@ ext { libs = [:] } -// Add Scala version -def defaultScala213Version = '2.13.17' -if (hasProperty('scalaVersion')) { - if (scalaVersion == '2.13') { Review Comment: removing this breaks the command `./gradlew clean build -x test -PscalaVersion=2.13` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
