iit2009060 commented on code in PR #20565:
URL: https://github.com/apache/kafka/pull/20565#discussion_r2388128430


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/metrics/ConsumerRebalanceMetricsManagerTest.java:
##########


Review Comment:
   Good point , Moved it in beforeeach.



##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/metrics/ConsumerRebalanceMetricsManagerTest.java:
##########
@@ -60,4 +62,239 @@ public void testAssignedPartitionCountMetric() {
         subscriptionState.assignFromSubscribed(Set.of(new 
TopicPartition("topic", 0)));
         assertEquals(1.0d, 
metrics.metric(consumerRebalanceMetricsManager.assignedPartitionsCount).metricValue());
     }
+
+    @Test
+    public void testRebalanceTimingMetrics() {
+        SubscriptionState subscriptionState = new 
SubscriptionState(mock(LogContext.class), AutoOffsetResetStrategy.EARLIEST);
+        ConsumerRebalanceMetricsManager metricsManager = new 
ConsumerRebalanceMetricsManager(metrics, subscriptionState);

Review Comment:
   Moved in beforeEach



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to