zheguang commented on code in PR #20057:
URL: https://github.com/apache/kafka/pull/20057#discussion_r2434485860
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/RaftClusterInvocationContext.java:
##########
@@ -145,6 +145,11 @@ public String bootstrapServers() {
return clusterTestKit.bootstrapServers();
}
+ @Override
+ public String bootstrapServers(ListenerName listenerName) {
Review Comment:
Can you provide the test that you want to use this method for? It'd provide
a context for me to see if there's other alternative.
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -121,9 +121,17 @@ default Set<Integer> brokerIds() {
/**
* The broker connect string which can be used by clients for bootstrapping
+ * using the broker listenerName
Review Comment:
This comment can be improved, in particular, the reference of listenerName
is unclear for an interface method here.
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java:
##########
@@ -121,9 +121,17 @@ default Set<Integer> brokerIds() {
/**
* The broker connect string which can be used by clients for bootstrapping
+ * using the broker listenerName
*/
String bootstrapServers();
+ /**
+ * The broker connect string which can be used by clients for bootstrapping
+ * using an alternate listener
+ * @throws org.apache.kafka.common.KafkaException if listenerName is not
defined
Review Comment:
By "not defined", did you mean a blank String, as in `Utils.isBlank(str)` or
null, or else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
