mjsax commented on code in PR #20668:
URL: https://github.com/apache/kafka/pull/20668#discussion_r2430893210
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##########
@@ -431,9 +431,9 @@ private StateConsumer initialize() {
} catch (final StreamsException fatalException) {
closeStateConsumer(stateConsumer, false);
startupException = fatalException;
- } catch (final Exception fatalException) {
+ } catch (final Throwable throwable) {
Review Comment:
Nit: it's still fatal, even if we change the type -- in general, we try to
use expressive names, and `throwable` is not an improvement over
`fatalException` I believe.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##########
@@ -431,9 +431,9 @@ private StateConsumer initialize() {
} catch (final StreamsException fatalException) {
closeStateConsumer(stateConsumer, false);
startupException = fatalException;
- } catch (final Exception fatalException) {
+ } catch (final Throwable throwable) {
Review Comment:
```suggestion
} catch (final Throwable fatalException) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
